Select correct coordinator for execute_command service #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case several hubs are registered, the service was called on the latest coordinator registered, which could thus be one not corresponding to the entity passed as argument. This fix allows to retrieve the coordinator attached to the given entity.
vlebourl
changed the title
|
can we merge ? |
iMicknl
reviewed
Apr 14, 2022
| e | ||
| for e in hass.data["entity_components"][registry_entry.domain].entities | ||
| if e.unique_id == registry_entry.unique_id | ||
| ][0] |
There was a problem hiding this comment.
You could perhaps also use next() here, instead of [0].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case several hubs are registered, the service was called on the latest coordinator registered, which could thus be one not corresponding to the entity passed as argument. This fix allows to retrieve the coordinator attached to the given entity.
can relate to #167