add device AtlanticPassAPCHeatingZone #785

jgarec · 2022-03-02T09:23:23Z

Closes #731

iMicknl

Thanks @jgarec! Appreciated :).

Since you mention WIP in the title, I marked your PR as a draft for now, so it won't accidentally get merged before you are finished.

jgarec · 2022-03-02T19:54:51Z

This component is concerned by #167

custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_zone.py

tetienne · 2022-03-02T20:52:58Z

custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_zone.py

+CUSTOM_PRESET_AUTO = "Auto"
+CUSTOM_PRESET_STOP = "Stop"
+
+COMMAND_REFRESH_COMFORT_HEATING_TARGET_TEMPERATURE = (


Can you please add all these states and commands to https://github.com/iMicknl/python-overkiz-api/tree/main/pyoverkiz/enums ?

Should i also add commands / states not used in this class ?

Only add the ones you need

custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_zone.py

tetienne · 2022-03-03T08:51:15Z

custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_zone.py

+    _attr_max_temp = 30
+    _attr_min_temp = 5


These values are not exposed by Atlantic?

not in this device (device number 7)

the navilink sensor (device number 8) have 2 attributes (from 5 to 30) :

2022-02-20 21:24:28 DEBUG (MainThread) [custom_components.tahoma] Unsupported device detected (Device(attributes=States(_states=[.... State(name='core:MaxSensedValue', type=<DataType.FLOAT: 2>, value=30.0), State(name='core:MinSensedValue', type=<DataType.FLOAT: 2>, value=5.0)]),available=True, enabled=True, label=** *(**#**)*, device_url=io://****-****-0589/12309249#8, controllable_name='io:AtlanticPassAPCZoneTemperatureSensor' ....

tahomalink allows to set a temperature between 7 and 35 ...

🤡 And what happens if you set 35? It's applied?
If the values are returned as you Show me, you can retrieve them into the init method using the linked device.

custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_zone.py

tetienne · 2022-03-03T08:58:35Z

custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_zone.py

+        if self.preset_mode == PRESET_COMFORT:
+            return self.executor.select_state(
+                CORE_COMFORT_HEATING_TARGET_TEMPERATURE_STATE
+            )
+        if self.preset_mode == PRESET_ECO:
+            return self.executor.select_state(CORE_ECO_HEATING_TARGET_TEMPERATURE_STATE)
+        if self.preset_mode == CUSTOM_PRESET_DEROGATION:
+            return self.executor.select_state(CORE_DEROGATED_TARGET_TEMPERATURE_STATE)
+
+        return self.executor.select_state(CORE_TARGET_TEMPERATURE_STATE)


Here also you can ease the code with a dict.

custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_zone.py

tetienne

Sorry for the number of comments.
As your code will be backport to the Core, I try to be as strict as they are (fairly).

…ting_zone.py Co-authored-by: Thibaut <[email protected]>

iMicknl · 2022-03-03T09:45:07Z

This component is concerned by #167

For what do you need this? There is a low chance that this will be implemented.

jgarec · 2022-03-03T09:53:49Z

This component is concerned by #167

For what do you need this? There is a low chance that this will be implemented.

If i change a state in HA then i can handle the refresh by myself. But if it's changed outstide then some states are not always refreshed and HA uses old known states

…ting_zone.py Co-authored-by: Thibaut <[email protected]>

…hub.com/jgarec/ha-tahoma into feat/support_AtlanticPassAPCHeatingZone

…ting_zone.py Co-authored-by: Thibaut <[email protected]>

iMicknl · 2022-03-03T10:50:11Z

This component is concerned by #167

For what do you need this? There is a low chance that this will be implemented.

If i change a state in HA then i can handle the refresh by myself. But if it's changed outstide then some states are not always refreshed and HA uses old known states

Makes sense... I will dive into this.

Could you add your diagnostics log here? I would love to understand more about your device :). Sorry for the strict reviews, but we would like to have this one ready directly for core as well. Some of our (older) climate implementations still need to be rewritten.
Happy to help with some refactors, if you don't want to spend time on that.

iMicknl · 2022-03-03T10:52:08Z

custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_zone.py

+            await self.executor.async_execute_command(
+                COMMAND_SET_DEROGATION_ON_OFF_STATE, "on"
+            )


Suggested change

await self.executor.async_execute_command(

COMMAND_SET_DEROGATION_ON_OFF_STATE, "on"

)

await self.executor.async_execute_command(

OverkizCommand.SET_DEROGATION_ON_OFF_STATE, OverkizCommandParam.ON

)

Would be great if you could use our enums here (and in all other executions). See https://github.com/home-assistant/core/blob/dev/homeassistant/components/overkiz/climate_entities/atlantic_electrical_heater.py.

However, many of these enums are probably missing and we need to add them to PyOverkiz.

iMicknl · 2022-11-07T20:34:37Z

@jgarec would you still be interested of porting this one to core? We are now moving all climate entities.

add device AtlanticPassAPCHeatingZone

1a45060

jgarec requested review from vlebourl, iMicknl and tetienne as code owners March 2, 2022 09:23

github-actions bot added the feature label Mar 2, 2022

iMicknl marked this pull request as draft March 2, 2022 09:24

iMicknl reviewed Mar 2, 2022

View reviewed changes

jgarec changed the title ~~WIP: add device AtlanticPassAPCHeatingZone~~ add device AtlanticPassAPCHeatingZone Mar 2, 2022

jgarec marked this pull request as ready for review March 2, 2022 19:53

tetienne requested changes Mar 2, 2022

View reviewed changes

custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_zone.py Show resolved Hide resolved

tetienne review

0336ac9

jgarec force-pushed the feat/support_AtlanticPassAPCHeatingZone branch from da6fb8d to 0336ac9 Compare March 3, 2022 08:25

tetienne reviewed Mar 3, 2022

View reviewed changes

custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_zone.py Outdated Show resolved Hide resolved

tetienne reviewed Mar 3, 2022

View reviewed changes

custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_zone.py Outdated Show resolved Hide resolved

tetienne reviewed Mar 3, 2022

View reviewed changes

custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_zone.py Outdated Show resolved Hide resolved

tetienne reviewed Mar 3, 2022

View reviewed changes

custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_zone.py Outdated Show resolved Hide resolved

tetienne reviewed Mar 3, 2022

View reviewed changes

custom_components/tahoma/climate_devices/atlantic_pass_apc_heating_zone.py Outdated Show resolved Hide resolved

tetienne reviewed Mar 3, 2022

View reviewed changes

Update custom_components/tahoma/climate_devices/atlantic_pass_apc_hea…

2fef79d

…ting_zone.py Co-authored-by: Thibaut <[email protected]>

jgarec and others added 4 commits March 3, 2022 11:03

Update custom_components/tahoma/climate_devices/atlantic_pass_apc_hea…

d6fce28

…ting_zone.py Co-authored-by: Thibaut <[email protected]>

use missing constants

524b35a

Merge branch 'feat/support_AtlanticPassAPCHeatingZone' of https://git…

afe1dc8

…hub.com/jgarec/ha-tahoma into feat/support_AtlanticPassAPCHeatingZone

typo

4a3d81b

jgarec and others added 2 commits March 3, 2022 11:11

Update custom_components/tahoma/climate_devices/atlantic_pass_apc_hea…

df639e5

…ting_zone.py Co-authored-by: Thibaut <[email protected]>

fix target_temperature complexity

d9f79a2

iMicknl reviewed Mar 3, 2022

View reviewed changes

Merge branch 'master' into feat/support_AtlanticPassAPCHeatingZone

78356fa

vlebourl requested a review from tetienne March 8, 2022 09:14

vlebourl added 2 commits April 7, 2022 23:54

Merge branch 'master' into feat/support_AtlanticPassAPCHeatingZone

3ab3c52

Merge branch 'master' into feat/support_AtlanticPassAPCHeatingZone

ec491fa

iMicknl closed this Feb 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add device AtlanticPassAPCHeatingZone #785

add device AtlanticPassAPCHeatingZone #785

jgarec commented Mar 2, 2022

iMicknl left a comment

jgarec commented Mar 2, 2022

tetienne Mar 2, 2022

jgarec Mar 3, 2022

tetienne Mar 3, 2022

tetienne Mar 3, 2022

jgarec Mar 3, 2022

tetienne Mar 3, 2022

tetienne Mar 3, 2022

tetienne left a comment

iMicknl commented Mar 3, 2022

jgarec commented Mar 3, 2022

iMicknl commented Mar 3, 2022 •

edited

Loading

iMicknl Mar 3, 2022 •

edited

Loading

iMicknl commented Nov 7, 2022

add device AtlanticPassAPCHeatingZone #785

add device AtlanticPassAPCHeatingZone #785

Conversation

jgarec commented Mar 2, 2022

iMicknl left a comment

Choose a reason for hiding this comment

jgarec commented Mar 2, 2022

tetienne Mar 2, 2022

Choose a reason for hiding this comment

jgarec Mar 3, 2022

Choose a reason for hiding this comment

tetienne Mar 3, 2022

Choose a reason for hiding this comment

tetienne Mar 3, 2022

Choose a reason for hiding this comment

jgarec Mar 3, 2022

Choose a reason for hiding this comment

tetienne Mar 3, 2022

Choose a reason for hiding this comment

tetienne Mar 3, 2022

Choose a reason for hiding this comment

tetienne left a comment

Choose a reason for hiding this comment

iMicknl commented Mar 3, 2022

jgarec commented Mar 3, 2022

iMicknl commented Mar 3, 2022 • edited Loading

iMicknl Mar 3, 2022 • edited Loading

Choose a reason for hiding this comment

iMicknl commented Nov 7, 2022

iMicknl commented Mar 3, 2022 •

edited

Loading

iMicknl Mar 3, 2022 •

edited

Loading