Add service to refresh state periodically #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMicknl
commented
Sep 18, 2020
iMicknl
commented
Sep 21, 2020
| @@ -191,10 +223,33 @@ async def async_unload_entry(hass: HomeAssistant, entry: ConfigEntry): | |||
|
|
|||
| async def update_listener(hass: HomeAssistant, entry: ConfigEntry): | |||
| """Update when config_entry options update.""" | |||
|
|
|||
| async def handle_refresh_states(*_): | |||
There was a problem hiding this comment.
This is the duplicate code I don't like that much.
iMicknl
force-pushed
the
feature/refresh_states
branch
3 times, most recently
from
791c116 to
02a2628
Compare
|
I am not sure if we should allow them to set this to 5 seconds, since it is a very 'expensive' call and it looks like you get 'TooManyRequests' exception when polling on a high interval. Currently we don't catch TooManyRequests exception that well in DataUpdateCoordinator. |
Signed-off-by: Mick Vleeshouwer <[email protected]>
Signed-off-by: Mick Vleeshouwer <[email protected]>
Signed-off-by: Mick Vleeshouwer <[email protected]>
Signed-off-by: Mick Vleeshouwer <[email protected]>
Signed-off-by: Mick Vleeshouwer <[email protected]>
Signed-off-by: Mick Vleeshouwer <[email protected]>
Signed-off-by: Mick Vleeshouwer <[email protected]>
Signed-off-by: Mick Vleeshouwer <[email protected]>
Signed-off-by: Mick Vleeshouwer <[email protected]>
Signed-off-by: Mick Vleeshouwer <[email protected]>
Signed-off-by: Mick Vleeshouwer <[email protected]>
Signed-off-by: Mick Vleeshouwer <[email protected]>
iMicknl
force-pushed
the
feature/refresh_states
branch
from
d419ce3 to
9fba7c0
Compare
|
PR has been tested and is fully functional, however I am still in doubt if we should disable this task by default. Maybe we should add a checkbox to enable this task. |
|
That looks like something that Somfy wouldn't like, especially if set with low values. I think it would be better not enabling that, especially by default, if it can get users/software in trouble. |
|
Agreed, I would leave that unchecked by default and let users be responsible for making an automation to use it. |
Indeed, I am on the same page. Currently the widely used |
|
@iMicknl as you know I would love for this to be pulled in to the master - my gate closes automatically two minutes after opening, which is not caught by Tahome unless I use an automation that calls the refresh service two minutes after my gate's state has changed from closed. I understand that caution is needed though. |
1 task
|
I think this one can be closed. This isn't something that will be added to core IMO. |
1 task
fetzerch
added a commit
to fetzerch/homeassistant-core
that referenced
this pull request
Sep 2, 2023
The Somfy Dexxo smart io (io:DiscreteGarageOpenerWithPartialPositionIOComponent) supports a third position state: partial. This state is meant to be used to ventilate the garage. This commit adds a select entity for the position state. The implementation is very similar to the already existing position state for gate's with a pedestrian position. Note: For the updates to work properly, we'd still need iMicknl/ha-tahoma#167 / iMicknl/ha-tahoma#271 to be implemented. See Somfy-Developer/Somfy-TaHoma-Developer-Mode#26 for discussion with Somfy.
fetzerch
added a commit
to fetzerch/homeassistant-core
that referenced
this pull request
Sep 2, 2023
The Somfy Dexxo smart io (io:DiscreteGarageOpenerWithPartialPositionIOComponent) supports a third position state: partial. This state is meant to be used to ventilate the garage. This commit adds a select entity for the position state. The implementation is very similar to the already existing position state for gate's with a pedestrian position. Note: For the updates to work properly, we'd still need iMicknl/ha-tahoma#167 / iMicknl/ha-tahoma#271 to be implemented. See Somfy-Developer/Somfy-TaHoma-Developer-Mode#26 for discussion with Somfy.
fetzerch
added a commit
to fetzerch/homeassistant-core
that referenced
this pull request
Sep 4, 2023
The Somfy Dexxo smart io (io:DiscreteGarageOpenerWithPartialPositionIOComponent) supports a third position state: partial. This state is meant to be used to ventilate the garage. This commit adds a select entity for the position state. The implementation is very similar to the already existing position state for gate's with a pedestrian position. Note: For the updates to work properly, we'd still need iMicknl/ha-tahoma#167 / iMicknl/ha-tahoma#271 to be implemented. See Somfy-Developer/Somfy-TaHoma-Developer-Mode#26 for discussion with Somfy.
fetzerch
added a commit
to fetzerch/homeassistant-core
that referenced
this pull request
Sep 4, 2023
The Somfy Dexxo smart io (io:DiscreteGarageOpenerWithPartialPositionIOComponent) supports a third position state: partial. This state is meant to be used to ventilate the garage. This commit adds a select entity for the position state. The implementation is very similar to the already existing position state for gate's with a pedestrian position. Note: For the updates to work properly, we'd still need iMicknl/ha-tahoma#167 / iMicknl/ha-tahoma#271 to be implemented. See Somfy-Developer/Somfy-TaHoma-Developer-Mode#26 for discussion with Somfy.
fetzerch
added a commit
to fetzerch/homeassistant-core
that referenced
this pull request
Sep 11, 2023
The Somfy Dexxo smart io (io:DiscreteGarageOpenerWithPartialPositionIOComponent) supports a third position state: partial. This state is meant to be used to ventilate the garage. This commit adds a select entity for the position state. The implementation is very similar to the already existing position state for gate's with a pedestrian position. Note: For the updates to work properly, we'd still need iMicknl/ha-tahoma#167 / iMicknl/ha-tahoma#271 to be implemented. See Somfy-Developer/Somfy-TaHoma-Developer-Mode#26 for discussion with Somfy.
fetzerch
added a commit
to fetzerch/homeassistant-core
that referenced
this pull request
Sep 28, 2023
The Somfy Dexxo smart io (io:DiscreteGarageOpenerWithPartialPositionIOComponent) supports a third position state: partial. This state is meant to be used to ventilate the garage. This commit adds a select entity for the position state. The implementation is very similar to the already existing position state for gate's with a pedestrian position. Note: For the updates to work properly, we'd still need iMicknl/ha-tahoma#167 / iMicknl/ha-tahoma#271 to be implemented. See Somfy-Developer/Somfy-TaHoma-Developer-Mode#26 for discussion with Somfy.
fetzerch
added a commit
to fetzerch/homeassistant-core
that referenced
this pull request
Sep 28, 2023
The Somfy Dexxo smart io (io:DiscreteGarageOpenerWithPartialPositionIOComponent) supports a third position state: partial. This state is meant to be used to ventilate the garage. This commit adds a select entity for the position state. The implementation is very similar to the already existing position state for gate's with a pedestrian position. Note: For the updates to work properly, we'd still need iMicknl/ha-tahoma#167 / iMicknl/ha-tahoma#271 to be implemented. See Somfy-Developer/Somfy-TaHoma-Developer-Mode#26 for discussion with Somfy.
20 tasks
iMicknl
pushed a commit
to fetzerch/homeassistant-core
that referenced
this pull request
Oct 10, 2023
The Somfy Dexxo smart io (io:DiscreteGarageOpenerWithPartialPositionIOComponent) supports a third position state: partial. This state is meant to be used to ventilate the garage. This commit adds a select entity for the position state. The implementation is very similar to the already existing position state for gate's with a pedestrian position. Note: For the updates to work properly, we'd still need iMicknl/ha-tahoma#167 / iMicknl/ha-tahoma#271 to be implemented. See Somfy-Developer/Somfy-TaHoma-Developer-Mode#26 for discussion with Somfy.
iMicknl
pushed a commit
to fetzerch/homeassistant-core
that referenced
this pull request
Nov 7, 2023
The Somfy Dexxo smart io (io:DiscreteGarageOpenerWithPartialPositionIOComponent) supports a third position state: partial. This state is meant to be used to ventilate the garage. This commit adds a select entity for the position state. The implementation is very similar to the already existing position state for gate's with a pedestrian position. Note: For the updates to work properly, we'd still need iMicknl/ha-tahoma#167 / iMicknl/ha-tahoma#271 to be implemented. See Somfy-Developer/Somfy-TaHoma-Developer-Mode#26 for discussion with Somfy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for calling
/setup/devices/states/refreshperiodically, using the existing data update coordinator.Fixes #167.