Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FullLDC tracking more flexible #72

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

Victor-Schwan
Copy link
Contributor

@Victor-Schwan Victor-Schwan commented Aug 21, 2024

BEGINRELEASENOTES

  • Remove the hardcoded (ILD) detector names from the FullLDC tracking to allow its usage with the v11 model of ILD.
    • Keep defaults compatible with the non-hybrid ILD models

ENDRELEASENOTES

@tmadlener
Copy link
Contributor

I have squashed all original commits and then rebased the result onto the reformatted master branch. It wasn't too bad in the end. Can you still check whether I didn't break anything accidentally?

removed printing of subdetector names

around line 949: streamlog of SIT layer check more verbose;
FullLDCTracking_MarlinTrk formatted using .clang-format

vscode setting json files added

introduced vars for subdetector names in setupGeom; less hardcoding

Relaxation of the condition on the vectors V and Z, antiparallel also permitted; experimental modification

tasks.json added

rm vscode specific files
@tmadlener tmadlener changed the title Add compatibility with detector models for circular colliders Make FullLDC tracking more flexible Aug 28, 2024
@tmadlener tmadlener merged commit 5da0b69 into iLCSoft:master Aug 28, 2024
4 of 7 checks passed
@Victor-Schwan Victor-Schwan deleted the PR_ild_at_FCCee branch August 29, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants