Fix possibly wrong behavior with std::remove_if
#192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Jun 24, 2024
| @@ -29,7 +28,7 @@ namespace IOIMPL { | |||
| //---------------------------------------------------------------------------- | |||
|
|
|||
| void LCEventLazyImpl::removeCollection(const std::string & name) { | |||
| std::remove_if( _blocks.begin(), _blocks.end(), [&]( const sio::block_ptr &blk ){ return (blk->name() == name) ; } ) ; | |||
| _blocks.erase( std::remove_if( _blocks.begin(), _blocks.end(), [&]( const sio::block_ptr &blk ){ return (blk->name() == name) ; } ), _blocks.end() ) ; | |||
There was a problem hiding this comment.
Do you by chance know if block_ptr is a smart pointer, or in any other way managed?
There was a problem hiding this comment.
It's a shared_ptr. Deletions were already happening in the remove_if because _blocks will have a first to be discarded with some elements and a second one with the elements that remain, but the first part + the second part isn't the same as the original vector, some may be repeated which means others have to be missing. Hard to explain, easier to test.
There was a problem hiding this comment.
OK. If it's managed than it's OK. I was just wondering whether we had to manually delete them before eraase
tmadlener
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
std::remove_ifalone only does some rearranging and changing elements of_blocks, and that doesn't seem what's intended there. If everyone is using C++20std::erase_ifcan be used instead of theerase - removeidiom.BEGINRELEASENOTES
std::remove_ifwith aerase - removeidiomENDRELEASENOTES