Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Update cmake configuraton to targets based approach #140

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[wip] Update cmake configuraton to targets based approach #140

wants to merge 6 commits into from

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Jun 4, 2021 •
edited
Loading

BEGINRELEASENOTES

  • Upgrade the cmake configuration of LCIO to the newer target based approach. That should make it easier to use LCIO as a dependency for other packages. Additionally it should become easier to remove quite a bit of cmake macro code that took charge of the dependency management, since that can now be handled by plain cmake.
  • Bump the minimum cmake version to 3.14

ENDRELEASENOTES

Fixes #133

  • Check that the "legacy variables" that are currently exported are really enough for downstream packages to use LCIO
    • Successfully built Marlin on top of this.
  • Check which cmake macros have become obsolete and remove them
    • MacroCheckPackageVersion.h is still used by FindCLHEP.cmake so that would need to be touched as well. Keeping it for the moment.
  • Check if all the build options that are available still work
  • TODOs from CMake configuration overhaul #133
    • Use FindPython
    • Make BUILD_TESTING behave as expected
  • root dict generation. At least avoid re-generation of these every build even when nothing changed.

@tmadlener tmadlener force-pushed the update-cmake branch 2 times, most recently from 2a0ec36 to add5cec Compare June 4, 2021 16:36
tmadlener added 5 commits June 7, 2021 11:01
@tmadlener
Make SIO cmake config more similar to standalone version
54df0ab
@tmadlener
Switch to target based cmake approach for LCIO targets
fcf43d8 
- Use SIO targets
- Define LCIO targets and export them properly for downstream usage
- Keep some package specific install variables to keep backwards
compatibility
@tmadlener
Add .gitignore with some defaults
fab7f25
@tmadlener
Make root dicts use target based definitions
ef18cb9
@tmadlener
Only build tests if asked for it
09b2654
@tmadlener tmadlener mentioned this pull request Apr 19, 2023
Open
4 tasks
@tmadlener tmadlener mentioned this pull request Aug 15, 2023
Merged
@jmcarcell jmcarcell mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake configuration overhaul
1 participant
@tmadlener