Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable reco for ILD_FCCee_v01/2 #150

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Enable reco for ILD_FCCee_v01/2 #150

merged 6 commits into from
Nov 18, 2024

Conversation

Victor-Schwan
Copy link
Contributor

BEGINRELEASENOTES

  • minimal requirements for reco with ILD_FCCee_v01/2 models satisfied
    ENDRELEASENOTES

@tmadlener
Copy link
Contributor

Do you want to add a run for this on CI? Or is it not yet ready?

tmadlener
tmadlener reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably have to think about a better solution for grouping the detector models than having different tuples and simply checking if the detector model is in there. However, I would do that in a separate PR.

.github/workflows/key4hep.yml Show resolved Hide resolved
@tmadlener tmadlener merged commit fb10b66 into iLCSoft:master Nov 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer left review comments

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Victor-Schwan @tmadlener @andresailer