Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to run standard reconstruction with perfect PFA #135

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

ggrenier
Copy link
Contributor

This changes allows to run perfect PandoraPFA using MCtruth. To run perfectPFA, a relation between Tracks and true MCParticles has to be provided. This relation is produced by the RecoMCTruthLinker which is run after.
When using perfectPFA, one needs the RecoMCTruthLinker to be run before Pandora for the track-truth association and after for the cluster-truth and reco-truth association.

BEGINRELEASENOTES
Add option to run different PFA type in Standard Reco and add an xml file to run perfect PandoraPFA based on MC truth.
ENDRELEASENOTES

…e to run perfect PandoraPFA based on MC truth
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

For my clarification is this related to iLCSoft/MarlinReco#125 (or does it even fix that)?

@ggrenier
Copy link
Contributor Author

ggrenier commented Jan 9, 2024

Hi @tmadlener

It is not related to the MarlinReco issue.

Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have quickly run this locally on our usual 3 ttbar events tests that we use for release testing and this runs without problems.

The changes also seem reasonable.

@tmadlener tmadlener merged commit 2b3da08 into iLCSoft:master Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants