-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some compiler warnings #10
Conversation
Looks like also gcc detects it some times? https://github.com/iLCSoft/GEAR/actions/runs/5574118486/jobs/10182304376?pr=10#step:4:303 |
ae835ad
to
9e487b5
Compare
The unused result warnings arise due to compiling with -DNDEBUG suppressing the assertions. The changes here will break compilation if assertions are enabled. It's probably better to add #undef NDEBUG to the start of the test source files so that we're actually testing what was intended. |
More warings have been fixed now and debug builds should work again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this should only have little actual usage, I am fine with these changes and would merge them, unless you still want to changes some things.
I think these should be fine, the cmake changes behave like they did before and for the rest they seem quite harmless but I haven't tested them because there aren't any tests. At least it builds and Marlin keeps working. |
BEGINRELEASENOTES
ENDRELEASENOTES
The fallthroughs I'm not sure if they are intended but I just left the current behavior...