Fix warnings about implicit copy constructor

iLCSoft · Jan 15, 2024 · cfd4273 · cfd4273
1 parent d321885
commit cfd4273
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 2 deletions.
diff --git a/include/gear/GEAR.h b/include/gear/GEAR.h
@@ -48,6 +48,7 @@ namespace gear {
 
   public: 
     virtual ~Exception()  { /*no_op*/; } 
+    Exception( const Exception& e ) = default ;
 
     Exception( const std::string& text ){
       message = "gear::Exception: " + text ;

diff --git a/include/gear/TrackerPlanesLayerLayout.h b/include/gear/TrackerPlanesLayerLayout.h
@@ -23,9 +23,15 @@ class TrackerPlanesMaterialLayer  {
 
 
 public:
+    /// Constructor
+    TrackerPlanesMaterialLayer() = default;
+
     /// Destructor.
     virtual ~TrackerPlanesMaterialLayer() { /* nop */; }
 
+    /// Copy-constructor.
+    TrackerPlanesMaterialLayer( const TrackerPlanesMaterialLayer& ) = default;
+
     virtual int getID() const = 0;
 
     /** */
@@ -136,9 +142,15 @@ class TrackerPlanesSensitiveLayer  {
 
 
 public:
+    /// Constructor
+    TrackerPlanesSensitiveLayer() = default;
+
     /// Destructor.
     virtual ~TrackerPlanesSensitiveLayer() { /* nop */; }
 
+    /// Copy-constructor.
+    TrackerPlanesSensitiveLayer( const TrackerPlanesSensitiveLayer& ) = default;
+
 
     /** ID of sensitive volume of layer layerIndex - layer indexing starts at 0
      *  for the layer closest to the beam source.*/
@@ -282,9 +294,16 @@ class TrackerPlanesSensitiveLayer  {
 class TrackerPlanesLayer  {
 
 public:
+
+    /// Constructor
+    TrackerPlanesLayer() = default;
+
     /// Destructor.
     virtual ~TrackerPlanesLayer() { /* nop */; }
 
+    // Copy-constructor.
+    TrackerPlanesLayer( const TrackerPlanesLayer& ) = default;
+
     /** Layer ID of nonsensitive volume of layer layerIndex - layer indexing starts at 0
      *  for the layer closest to the beam source.*/
     virtual int getID() const = 0;

diff --git a/include/gear/gearimpl/FTDLayerLayoutImpl.h b/include/gear/gearimpl/FTDLayerLayoutImpl.h
@@ -26,7 +26,6 @@ class vframe  // TO BE DEPRECATED...
 		vframe(): x(0),y(0),z(0) { ; }
 		vframe(const double & xval, const double & yval, const double & zval):
 			x(xval),y(yval),z(zval) { ; }
-		~vframe() { ; }
 
 		double x{};
 		double y{};

diff --git a/include/gear/gearimpl/TrackerPlanesLayerLayoutImpl.h b/include/gear/gearimpl/TrackerPlanesLayerLayoutImpl.h
@@ -53,6 +53,8 @@ class TrackerPlanesMaterialLayerImpl: public TrackerPlanesMaterialLayer  {
     /// Destructor.
     /**      */
     virtual ~TrackerPlanesMaterialLayerImpl() { /* nop */; }
+    /// Copy constructor.
+    TrackerPlanesMaterialLayerImpl(const TrackerPlanesMaterialLayerImpl&) = default;
     /**      */
     virtual int getID() const { return ID  ; }
     /**      */
@@ -159,6 +161,9 @@ class TrackerPlanesSensitiveLayerImpl: public TrackerPlanesSensitiveLayer   {
     /// Destructor.
     virtual ~TrackerPlanesSensitiveLayerImpl() { /* nop */; }
 
+    /// Copy constructor.
+    TrackerPlanesSensitiveLayerImpl(const TrackerPlanesSensitiveLayerImpl&) = default;
+
     /**      */
     virtual int getID() const { return ID  ; }
     /**      */
@@ -284,6 +289,9 @@ class TrackerPlanesLayerImpl: public TrackerPlanesLayer  {
     /** Destructor.
      */
     virtual ~TrackerPlanesLayerImpl() { /* nop */; }
+    /** Copy constructor.
+     */
+    TrackerPlanesLayerImpl(const TrackerPlanesLayerImpl&) = default;
 
     /** get methods
      */

diff --git a/src/gearimpl/FTDLayerLayoutImpl.cc b/src/gearimpl/FTDLayerLayoutImpl.cc
@@ -226,7 +226,7 @@ double FTDLayerLayoutImpl::getThicknessForAngle(const int & layerIndex,const dou
 	//                  -si entra por el petalo
 	//                  -cual es la distancia que recorre antes de salir
 	//                  -para ello hay que controlar si sale antes de que
-	//                   acabe el petalo, en Y es fácil pero en x, al ser
+	//                   acabe el petalo, en Y es facil pero en x, al ser
 	//                   un petalo, la distancia es variable y dependera
 	//                   de la zona Y de salida del rayo
 	//                  -controlar y prohibir angulos que no esten en