Add possibility to include SDHCalContent and AprilContent #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tent during compilation
Inclusion of SDHCALContent and APRILContent
andresailer
commented
Mar 5, 2024
| INCLUDE_DIRECTORIES( SYSTEM ${SDHCALContent_INCLUDE_DIRS} ) | ||
| LINK_LIBRARIES( ${SDHCALContent_LIBRARIES} ) | ||
| ADD_DEFINITIONS ( ${SDHCALContent_DEFINITIONS} ) | ||
| ADD_DEFINITIONS( "-DSDHCALCONTENT" ) |
There was a problem hiding this comment.
Suggested change
| ADD_DEFINITIONS( "-DSDHCALCONTENT" ) | |
| ADD_DEFINITIONS( "SDHCALCONTENT" ) |
Cmake will add the -D where necessary
andresailer
commented
Mar 5, 2024
| INCLUDE_DIRECTORIES( SYSTEM ${APRILContent_INCLUDE_DIRS} ) | ||
| LINK_LIBRARIES( ${APRILContent_LIBRARIES} ) | ||
| ADD_DEFINITIONS ( ${APRILContent_DEFINITIONS} ) | ||
| ADD_DEFINITIONS( "-DAPRILCONTENT" ) |
There was a problem hiding this comment.
Suggested change
| ADD_DEFINITIONS( "-DAPRILCONTENT" ) | |
| ADD_DEFINITIONS( "APRILCONTENT" ) |
andresailer
commented
Mar 5, 2024
| @@ -0,0 +1,18 @@ | |||
| IF(NOT DEFINED mlpack_DIR) | |||
There was a problem hiding this comment.
mlpack should come with a cmake config file, so this findmlpack should not be needed
https://github.com/mlpack/mlpack/blob/master/CMake/mlpack-config.cmake.in
andresailer
commented
Mar 5, 2024
| @@ -0,0 +1,18 @@ | |||
| IF(NOT DEFINED mlpack_DIR) | |||
| MESSAGE(STATUS "Warning: it is mandorary to define mlpack_DIR.") | |||
There was a problem hiding this comment.
Suggested change
| MESSAGE(STATUS "Warning: it is mandorary to define mlpack_DIR.") | |
| MESSAGE(FATAL_ERROR "It is mandatory to define mlpack_DIR.") | |
|
Superseded by #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES