-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add user, system certificate in existing network security config #3724
Conversation
…er than creating a fresh config
@iBotPeaches Can you review this? |
Its only been 5 minutes lol. I can't work that fast. |
Rather than comparing exact string, parse and check if user and system certificate exist
cc @erev0s as you added this feature. In case you have any feedback/comments on this addition. |
thanks @iBotPeaches for the tag to check it. |
So, @iBotPeaches @erev0s what can be the next action here? |
thanks! |
With
-n
flag:Current flow: creates a new network_security_config and updates in manifest
Updated flow: check if network_security_config exist, if not, create a new one (current approach) else modify network_security_config to add certificate without losing other rules added by user. i.e whitelisting any domain.