Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added renderTaglist #71

Merged
merged 1 commit into from
Jun 15, 2024
Merged

added renderTaglist #71

merged 1 commit into from
Jun 15, 2024

Conversation

ellunium
Copy link
Contributor

@ellunium ellunium commented Jun 7, 2024

Added the renderTagList prop with test, examples and description to readme.

@i-like-robots Like I said, it's not much , but could you please review? I think the TagList component needs optimising, maybe needs props? Let me know hat you think. Thanks!

Added the renderTagList prop with test, examples and description to readme.
@i-like-robots i-like-robots self-assigned this Jun 10, 2024
@coveralls
Copy link

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9415315860

Details

  • 28 of 28 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 93.197%

Totals Coverage Status
Change from base Build 7907714774: 0.09%
Covered Lines: 1509
Relevant Lines: 1624

💛 - Coveralls

@i-like-robots
Copy link
Owner

Thanks for your contribution @ellunium and for the nice example too. I should be able to review and test this week 👍

Copy link
Owner

@i-like-robots i-like-robots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution - I'm going to merge this but make a few changes before releasing. I intend to refactor all of the list props into the useTagList hook so that it is consistent with the other custom renderers and implementors can create a custom list like below using spread rather than declaring each attribute individually:

<div className={classNames.tagList} {...tagListProps}>
  {children.map((child) => (
    <div className={classNames.tagListItem} key={child.key}>
      {child}
    </div>
  ))}
</div>

@ellunium
Copy link
Contributor Author

ellunium commented Jun 15, 2024

Thanks for your contribution - I'm going to merge this but make a few changes before releasing. I intend to refactor all of the list props into the useTagList hook so that it is consistent with the other custom renderers and implementors can create a custom list and spread the props rather than declaring each attribute individually:

<div className={classNames.tagList} {...tagListProps}>
  {children.map((child) => (
    <div className={classNames.tagListItem} key={child.key}>
      {child}
    </div>
  ))}
</div>

Makes perfect sense!

@i-like-robots i-like-robots merged commit a72e6be into i-like-robots:main Jun 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants