Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update_example_files #10

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

alexdzm
Copy link
Contributor

@alexdzm alexdzm commented Nov 21, 2024

Context

We include full gate csvs, these are a standard IPA asset. A pdf is now in the example set

This PR contains:

  • New features
  • Changes to dev-tools e.g. CI config / github tooling
  • Bug fixes
  • Code refactor

Copy link
Contributor

@nmenezes0 nmenezes0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tests need to be updated - test_CreateDBPipeline.py and test_LLMFlag.py.

@alexdzm alexdzm changed the base branch from feature/readme-improvements to main November 21, 2024 14:40
@alexdzm
Copy link
Contributor Author

alexdzm commented Nov 21, 2024

Sorry, can you narrow down witch parts of the tests?

@nmenezes0
Copy link
Contributor

Sorry, can you narrow down witch parts of the tests?

The number of chunks will be different:

def test_create_db_from_local_dir(

And the number of results depending on which criteria I think?

expected_counts = {**pre_flag_counts, "result": 3}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants