Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape output #234

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Escape output #234

wants to merge 5 commits into from

Conversation

harvitronix
Copy link
Contributor

I re-did the output escaping as I was originally double escaping some output.

One issue we may have is with late escaping. You escape quite a bit of output early, and so it looks like the output isn't escaped on echo. This doesn't present a security problem in itself, but VIP dislikes it as it's easy to miss something in the future. Their explanation is here: https://vip.wordpress.com/2014/06/20/the-importance-of-escaping-all-the-things/

I'm not sure if this will end up being a blocker, but it's something to consider.

For now, I've left escaping where it is, and added it in places I did not see it escaped prior.

I did a manual QA: adding all the components pre- and post-escaping and the diff passed. But I'm not as familiar with this as you are, so it's worth another check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant