Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HEENDY-87-fix-icon-API] 유저용 쿠폰, 이벤트 조회 시 아이콘 포함 #24

Merged
merged 1 commit into from
Mar 2, 2024
Merged

[HEENDY-87-fix-icon-API] 유저용 쿠폰, 이벤트 조회 시 아이콘 포함 #24

merged 1 commit into from
Mar 2, 2024

Conversation

sangeun99
Copy link
Member

구현 사항

  • 유저용 쿠폰, 이벤트 조회 시 아이콘 포함
  • 유저용 현재 이벤트 전체 조회 (GET /api/v1/events)
  • 유저용 모든 쿠폰 전체 조회 (GET /api/v1/coupons)

참고 사항

  • S3 icon/ 폴더에 저장된 이미지 url로 이용 (현재는 아이콘 하나만 업로드 되어있음)
  • DB 쿠폰, 이벤트 테이블에 icon_url 컬럼 추가

POSTMAN 스크린샷

유저용 현재 이벤트 전체 조회 (GET /api/v1/events)

image

유저용 모든 쿠폰 전체 조회 (GET /api/v1/coupons)

image

@sangeun99 sangeun99 added 🐞 fix 버그 수정 🐻‍❄️ 연유 @sangeun99 🔥 H-1 1시간 안에 리뷰해주세요 labels Mar 2, 2024
@sangeun99 sangeun99 self-assigned this Mar 2, 2024
@sangeun99 sangeun99 requested a review from osy9757 March 2, 2024 06:28
osy9757
osy9757 approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@osy9757 osy9757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했어요~

@osy9757 osy9757 merged commit e08e2e5 into dev Mar 2, 2024
2 checks passed
@sooyoungh sooyoungh deleted the HEENDY-87-fix-icon-API branch March 3, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osy9757 osy9757 osy9757 approved these changes

Assignees

@sangeun99 sangeun99

Labels
🐞 fix 버그 수정 🐻‍❄️ 연유 @sangeun99 🔥 H-1 1시간 안에 리뷰해주세요
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sangeun99 @osy9757