Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route connection #41

Merged
merged 11 commits into from
Oct 26, 2024
Merged

Route connection #41

merged 11 commits into from
Oct 26, 2024

Conversation

jjoel1630
Copy link
Contributor

No description provided.

ryanlau
ryanlau requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@ryanlau ryanlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionally, make sure npm run build passes or else these changes cannot be deployed!

src/components/PreviewCard.tsx Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
src/routes/root.tsx Outdated Show resolved Hide resolved
src/routes/root.tsx Outdated Show resolved Hide resolved
@jjoel1630 jjoel1630 requested a review from ryanlau October 25, 2024 02:51
ryanlau
ryanlau requested changes Oct 26, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
src/components/SearchBar.tsx Show resolved Hide resolved
BANANAPEEL202
BANANAPEEL202 approved these changes Oct 26, 2024
View reviewed changes
Copy link
Collaborator

@BANANAPEEL202 BANANAPEEL202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with new mock and works as expected

@jjoel1630 jjoel1630 requested a review from ryanlau October 26, 2024 02:58
@BANANAPEEL202 BANANAPEEL202 linked an issue Oct 26, 2024 that may be closed by this pull request
Route Connection #25
Closed
@jjoel1630 jjoel1630 merged commit 69f75e8 into main Oct 26, 2024
1 check passed
@jjoel1630 jjoel1630 deleted the route-connection branch October 26, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BANANAPEEL202 BANANAPEEL202 BANANAPEEL202 approved these changes

@ryanlau ryanlau ryanlau approved these changes

@SreeDan SreeDan Awaiting requested review from SreeDan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route Connection
3 participants
@jjoel1630 @ryanlau @BANANAPEEL202