Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab 1 Part 2 #32

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Lab 1 Part 2 #32

wants to merge 4 commits into from

Conversation

12458
Copy link
Contributor

@12458 12458 commented Sep 1, 2024

No description provided.

@12458 12458 requested a review from chungchunwang September 1, 2024 21:56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not include extraneous generated files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment about generated files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment about generated files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment about generated files

@@ -0,0 +1,52 @@
{
description = "vectornav c++ library";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect description 🥸

Comment on lines +11 to +13
vn_lib_overlay = final: prev: {
vn_lib = final.callPackage ./default.nix { };
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls rename

vn_lib_overlay = final: prev: {
vn_lib = final.callPackage ./default.nix { };
};
my_overlays = [ easy_cmake.overlays.default vn_lib_overlay ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment about unnecessary easy_cmake

Comment on lines +25 to +27
vn_lib = pkgs.vn_lib;
py_vn_lib = pkgs.py_vn_lib;
default = vn_lib;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls rename

packages = with pkgs; [
# Development Tools
cmake
vn_lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not include your result symlink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants