replacing existing fullscreen #8566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows replacement of fullscreen window(i.e. fullscreening another window when one is already fullscreened on the workspace) this is used when a floating window that is spawned on top of a fullscreen wanted to be fullscreened
|
should this even be gated? |
|
i mean, someone didn't implement this at the first place for a reason, but I'll remove it |
littleblack111
changed the title
binds:allow_replace_fullscreen
|
there is an issue now, if you have a fullscreen window and replace it with a floating pinned window, that originally fullscreened window won't restore back to fullscreen after un-fullscreening the floating pinned window. don't know how to fix |
|
try removing the pin status? unsure |
|
ahh, no one prob gonna notice anyway, how abt merge it for now and fix it if it turned into a more severe issue also rn theres a issue with pin that can be fixed with this(if u try to fullscreen the pinned window when another window is fullscreened, it'd mess up that var that stores the pin state). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
this allows replacement of fullscreen window(i.e. fullscreening another window when one is already fullscreened on the workspace)
this is used when a floating window that is spawned on top of a fullscreen wanted to be fullscreened
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
no
Is it ready for merging, or does it need work?
ready