Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dispatchers, add hidespecialworkspace #6862

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Bartkk0
Copy link

@Bartkk0 Bartkk0 commented Jul 13, 2024

Describe your PR, what does it fix/add?

Adds a dispatcher hidespecialworkspace that hides the current special workspace

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

I don't think so

Is it ready for merging, or does it need work?

I think it's ready for merging

@Eclextic
Copy link

Hide as in, don't show the special workspace anymore or hide as in, make it inaccessible?

@Bartkk0
Copy link
Author

Bartkk0 commented Jul 13, 2024

Hide as in, don't show the special workspace anymore or hide as in, make it inaccessible?

Hide as in don't show it anymore

@MightyPlaza
Copy link
Contributor

MightyPlaza commented Jul 13, 2024

i think it would make more sense to add an arg to togglespecialworkspace (like 0/1/toggle) or create a new dispatcher that could open, close and toggle instead of creating one just to close it
also vaxry will want a wiki MR

@vaxerski
Copy link
Member

mightyplaza is right on both fronts

@Eclextic
Copy link

Eclextic commented Jul 13, 2024

i think it would make more sense to add an arg to togglespecialworkspace (like 0/1/toggle) or create a new dispatcher that could open, close and toggle instead of creating one just to close it also vaxry will want a wiki MR

Yeah I agree, that's what confused me a bit... The togglespecialworkspace functionality closely resembles what you are trying to do, so it should probably become an argument.

Also I can't think of a case where anyone would need to just close the special workspace instead of toggling it...

@Bartkk0
Copy link
Author

Bartkk0 commented Jul 13, 2024

for me the use case is to hide the currently visible special workspace, togglespecialworkspace could have an additional argument, but it would also need to handle referring to the current workspace

@Kommynct
Copy link

Kommynct commented Jul 14, 2024

Always hiding the special workspace would be useful for making it so that when you switch to a workspace the special workspace always hides

I currently use this bound to every single workspace hotkey for this and it'd certainly simplify that

hyprctl monitors -j | jaq -r '.[] | select(.focused == true) | .specialWorkspace.name' | sd 'special:' '' | xargs -I [] hyprctl dispatch togglespecialworkspace []

@dxrcy
Copy link

dxrcy commented Nov 28, 2024

#8594 provides alternative solutions which may be of use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants