Task to fill up the AnnotationSlim table in the background #8269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
force-pushed
the
fill-slim-task
branch
from
5bb6060 to
1767d8d
Compare
marcospri
commented
Oct 24, 2023
h/tasks/annotations.py
Outdated
| .outerjoin(AnnotationSlim) | ||
| .outerjoin(AnnotationModeration) | ||
| .where(AnnotationSlim.id.is_(None)) | ||
| .order_by(Annotation.created.asc()) |
There was a problem hiding this comment.
I'm thinking it maybe be best to sort by desc, have the most recent ones here will be useful sooner than the old ones from years ago.
There was a problem hiding this comment.
👍 Might want to use updated instead too
seanh
approved these changes
Oct 24, 2023
h/tasks/annotations.py
Outdated
| .outerjoin(AnnotationSlim) | ||
| .outerjoin(AnnotationModeration) | ||
| .where(AnnotationSlim.id.is_(None)) | ||
| .order_by(Annotation.created.asc()) |
There was a problem hiding this comment.
👍 Might want to use updated instead too
SQL based, a CTE selects all the data for the annotation slim table that an INSERT adds to the slim table. This reverts commit b6301df.
marcospri
force-pushed
the
fill-slim-task
branch
from
1767d8d to
c706ccf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
docker compose exec postgres psql -U postgres -c "truncate annotation_slim cascade"make shell:Wait for the task to fiinish on
make devlogs:Task h.tasks.annotations.fill_annotation_slim[a64c0f1a-e98b-450b-a9aa-aea4998cee9a] succeeded in 0.02210914299939759s: NoneQuery the created slim records
docker compose exec postgres psql -U postgres -c "select * from annotation_slim"