Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show survey to users after extension is uninstalled #1658

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Show survey to users after extension is uninstalled #1658

merged 1 commit into from
Dec 20, 2024

Conversation

robertknight
Copy link
Member

Fixes hypothesis/product-backlog#1599

Testing:

  1. Build and install development extension
  2. Uninstall the extension
  3. Chrome should open a new tab at this URL

@robertknight robertknight requested a review from acelaya December 20, 2024 10:29
acelaya
acelaya approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@acelaya acelaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertknight robertknight merged commit 33c88f5 into main Dec 20, 2024
2 checks passed
@robertknight robertknight deleted the uninstall-survey branch December 20, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acelaya acelaya acelaya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a page that shows up when people uninstall the Chrome extension
2 participants
@robertknight @acelaya