Migrate to ESLint 9 and ESLint flat config #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
commented
Oct 17, 2024
Comment on lines
+15
to
+16
| // TODO - Lint these files | ||
| 'rollup*.config.js', |
There was a problem hiding this comment.
I kept these ignored as it was before. We can change this later.
acelaya
commented
Oct 17, 2024
Comment on lines
+30
to
+31
| "eslint-plugin-react": "^7.37.1", | ||
| "eslint-plugin-react-hooks": "^5.0.0", |
There was a problem hiding this comment.
This project does not really need these two plugins, but they are eslint-config-hypothesis peer dependencies.
There was a problem hiding this comment.
We could add separate entry points in future for Preact and non-Preact using libs/apps.
robertknight
requested changes
Oct 17, 2024
robertknight
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update project to ESLint 9 and migrate ESlint config to flat format.
For this migration some eslint plugins needed to be updated:
*
@typescript-eslint/...packages replaced bytypescript-eslintand updated to v8*
eslint-plugin-react-hooksupdated to v5*
eslint-plugin-mochaupdated to v10.5*
eslint-plugin-reactupdated to v7.37*
eslint-config-hypothesisupdated to v3