Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APA URL prefixes to embed list #158

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Add APA URL prefixes to embed list #158

merged 1 commit into from
Sep 28, 2018

Conversation

robertknight
Copy link
Member

Depends on #155

Add the URL prefixes supplied by APA to the list of URL patterns assumed to embed the Hypothesis client and therefore not require Via.

Fixes hypothesis/product-backlog#814

@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #158   +/-   ##
======================================
  Coverage    91.2%   91.2%           
======================================
  Files          12      12           
  Lines         580     580           
======================================
  Hits          529     529           
  Misses         51      51
Impacted Files Coverage Δ
bouncer/embed_detector.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1470c2f...77d264b. Read the comment docs.

@robertknight robertknight merged commit 1137aca into master Sep 28, 2018
@robertknight robertknight deleted the apa-embed-list branch September 28, 2018 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share links not working for APA articles
2 participants