Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement sign transaction pages #378

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

Zied-Dahmani
Copy link
Collaborator

@Zied-Dahmani Zied-Dahmani commented Nov 27, 2024

Scope

Ticket

I implemented the sign transaction pages for the casting vote process and optimized/cleaned up the code to improve readability and adhere to coding standards.

Screenshots:

Success Failure

@Zied-Dahmani Zied-Dahmani requested a review from n13 November 27, 2024 18:12
@Zied-Dahmani Zied-Dahmani self-assigned this Nov 27, 2024
@Zied-Dahmani Zied-Dahmani linked an issue Nov 27, 2024 that may be closed by this pull request
@n13
Copy link
Collaborator

n13 commented Nov 29, 2024

Can you put screenshots there? Or did no screens change?

Copy link
Collaborator

@n13 n13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it - I would like to see screenshots though for all added screens, error screens, and error and success conditions.

@Zied-Dahmani
Copy link
Collaborator Author

Let's try it - I would like to see screenshots though for all added screens, error screens, and error and success conditions.

I just added screenshots; they show the same screens but with different texts.

@Zied-Dahmani Zied-Dahmani merged commit 089c876 into main Nov 29, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Vote Casting Issue
2 participants