Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proposals loading issue #376

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

Zied-Dahmani
Copy link
Collaborator

Scope

Ticket

This PR resolves an issue where proposals load infinitely. The problem arises when you scan a QR code or create a proposal, and the app returns you to the first page (bottom navigation). In this case, the initial event for the proposals bloc is triggered again, but the success state is not emitted, resulting in proposals loading indefinitely.

@Zied-Dahmani Zied-Dahmani requested a review from n13 November 21, 2024 13:04
@Zied-Dahmani Zied-Dahmani self-assigned this Nov 21, 2024
@Zied-Dahmani Zied-Dahmani linked an issue Nov 21, 2024 that may be closed by this pull request
Copy link
Collaborator

@n13 n13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zied-Dahmani Zied-Dahmani merged commit 89296ce into main Nov 25, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Proposals Bloc Issue
2 participants