Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: display dao and creator images #312

Merged
merged 5 commits into from
Sep 17, 2024
Merged

refactor: display dao and creator images #312

merged 5 commits into from
Sep 17, 2024

Conversation

Zied-Dahmani
Copy link
Collaborator

@Zied-Dahmani Zied-Dahmani commented Sep 12, 2024 •
edited
Loading

Scope

Ticket

I have implemented the logic to display DAO and creator images on the proposal card.

Screenshots

Image 2

@Zied-Dahmani Zied-Dahmani requested a review from n13 September 12, 2024 15:17
@Zied-Dahmani Zied-Dahmani self-assigned this Sep 12, 2024
@Zied-Dahmani Zied-Dahmani linked an issue Sep 12, 2024 that may be closed by this pull request
Display DAO and Creator Images on the Proposal Card #311
Closed
@Zied-Dahmani Zied-Dahmani deleted the chore/implement-dao-and-creator-image branch September 12, 2024 15:19
@Zied-Dahmani Zied-Dahmani restored the chore/implement-dao-and-creator-image branch September 12, 2024 15:19
@Zied-Dahmani Zied-Dahmani reopened this Sep 12, 2024
n13
n13 reviewed Sep 14, 2024
View reviewed changes
Copy link
Collaborator

@n13 n13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n13
Copy link
Collaborator

n13 commented Sep 16, 2024 •
edited
Loading

Why has it been closed and re-opened?
Approving since I don't want to hold up development

@Zied-Dahmani
Copy link
Collaborator Author

Why has it been closed and re-opened? Approving since I don't want to hold up development

I renamed the branch.

@Zied-Dahmani Zied-Dahmani merged commit 5879997 into main Sep 17, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n13 n13 n13 approved these changes

Assignees

@Zied-Dahmani Zied-Dahmani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display DAO and Creator Images on the Proposal Card
2 participants
@Zied-Dahmani @n13