Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve various UI bugs #293

Merged
merged 3 commits into from
Aug 30, 2024
Merged

fix: Resolve various UI bugs #293

merged 3 commits into from
Aug 30, 2024

Conversation

nbetsaif
Copy link
Collaborator

@nbetsaif nbetsaif commented Aug 27, 2024 •
edited
Loading

Scope

Ticket

  • Fixed margin issue on the bottom navbar to ensure it doesn’t obscure content.
  • Adjusted body layout to prevent background color from showing around the navbar.
  • Made DAO name visible on the proposal card in light mode.
  • Resolved overflow issue on the profile screen.

Screenshots

Before After
before after
Before After
before after
Before After
before after

@nbetsaif nbetsaif added the Bug Something isn't working label Aug 27, 2024
@nbetsaif nbetsaif requested a review from n13 August 27, 2024 13:28
@nbetsaif nbetsaif self-assigned this Aug 27, 2024
@nbetsaif nbetsaif linked an issue Aug 27, 2024 that may be closed by this pull request
UI Issues: Bottom Navbar, Proposal Card, and Profile Screen #291
Closed
@nbetsaif nbetsaif changed the title fix:Fix various UI bugs fix: Fix various UI bugs Aug 27, 2024
@nbetsaif nbetsaif changed the title fix: Fix various UI bugs fix: Resolve various UI bugs Aug 27, 2024
n13
n13 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@n13 n13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@nbetsaif nbetsaif merged commit fb7d8e9 into main Aug 30, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n13 n13 n13 approved these changes

Assignees

@nbetsaif nbetsaif

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI Issues: Bottom Navbar, Proposal Card, and Profile Screen
2 participants
@nbetsaif @n13