Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/android onboarding #277

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Bugfix/android onboarding #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7de751b
Update Podfile.lock
n13 Jul 2, 2024
be84a08
launching external in Android - works better
n13 Jul 3, 2024
d566e70
increased build number a few times
n13 Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,7 +1064,7 @@ SPEC CHECKSUMS:
FirebaseMessaging: bb2c4f6422a753038fe137d90ae7c1af57251316
FirebaseRemoteConfig: bc7f260e6596956fafbb532443c19bd3c30f5258
FirebaseSessions: 96e7781e545929cde06dd91088ddbb0841391b43
Flutter: f04841e97a9d0b0a8025694d0796dd46242b2854
Flutter: e0871f40cf51350855a761d2e70bf5af5b9b5de7
flutter_secure_storage: 23fc622d89d073675f2eaa109381aefbcf5a49be
GoogleAppMeasurement: 2d800fab85e7848b1e66a6f8ce5bca06c5aad892
GoogleDataTransport: 54dee9d48d14580407f8f5fbf2f496e92437a2f2
Expand Down Expand Up @@ -1096,4 +1096,4 @@ SPEC CHECKSUMS:

PODFILE CHECKSUM: b347bf786bcbbd0a76929a5f65d30a5cde8fd52f

COCOAPODS: 1.12.1
COCOAPODS: 1.15.2
6 changes: 5 additions & 1 deletion lib/ui/onboarding/onboarding_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import 'dart:io' show Platform;

import 'package:flutter/material.dart';
import 'package:flutter_svg/flutter_svg.dart';
import 'package:get/get.dart';
Expand All @@ -21,7 +23,9 @@ class OnboardingPage extends StatelessWidget {
final _url = GetIt.I.get<RemoteConfigService>().signUpLinkUrl;
if (!await launchUrl(
Uri.parse(_url),
mode: LaunchMode.inAppWebView,
// We launch in app web view in iOS because App review requires it.
// We launch external browser in Android because it works much better.
mode: Platform.isIOS ? LaunchMode.inAppWebView : LaunchMode.externalApplication,
)) {
ScaffoldMessenger.of(context).showSnackBar(const SnackBar(
content: Text('Error Launching URL. Please visit dao.hypha.earth'),
Expand Down
1 change: 0 additions & 1 deletion lib/ui/token/token_details/components/token_details_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import 'package:hypha_wallet/design/progress_indicator/hypha_progress_indicator.
import 'package:hypha_wallet/design/themes/extensions/theme_extension_provider.dart';
import 'package:hypha_wallet/ui/search_user/search_user_page.dart';
import 'package:hypha_wallet/ui/token/token_details/interactor/token_details_bloc.dart';
import 'package:hypha_wallet/ui/transfer_tokens/receive/receive_page.dart';
import 'package:hypha_wallet/ui/wallet/components/recent_transactions_view.dart';
import 'package:hypha_wallet/ui/wallet/data/wallet_token_data.dart';

Expand Down
4 changes: 2 additions & 2 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
# In Windows, build-name is used as the major, minor, and patch parts
# of the product and file versions while build-number is used as the build suffix.
version: 1.2.2+60
version: 1.2.2+62

environment:
sdk: '>=3.0.0 <4.0.0'
Expand All @@ -38,7 +38,7 @@ dependencies:
cupertino_icons: ^1.0.2

# UI and Navigation
get: ^4.6.6
get: ^4.6.5

# State Management
flutter_bloc: ^8.1.3
Expand Down
Loading