Feature/pay cpu 2 0 #268
Merged
Feature/pay cpu 2 0 #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newer accounts created by us can use free cpu action also never fail with the getFreeCPU action - it should never prevent the popup from appearing. It is a bonus feature.
and newAccountFreshnessHours
gguijarro-c-chwy
approved these changes
Oct 21, 2023
| final result = await eosService.getAccount(user.accountName, network); | ||
| final freshHours = remoteConfigService.newAccountFreshnessHours; | ||
| if (result.isValue) { | ||
| if (DateTime.now().difference(result.asValue!.value.created!).inHours < freshHours) { |
There was a problem hiding this comment.
Should we make the created field in the account non billable?
There was a problem hiding this comment.
non nullable right? the problem is this is the old eosdart code and I didn't want to touch that.
created is always defined
| @@ -207,6 +209,8 @@ class RemoteConfigService { | |||
| 'signUpEnabled': true, | |||
| "signUpLinkUrl": "https://dao.hypha.earth/hypha/login", | |||
| 'walletEnabled': false, | |||
| 'newAccountFreshnessHours': 48, | |||
| 'payCpuEnabledNetwork': json.encode({"telos": false, "telosTestnet": true, "eos": true, "eosTestnet": true}) | |||
There was a problem hiding this comment.
Don't forget to add these to firebase
There was a problem hiding this comment.
payCpuEnabledNetwork had been only in firebase, adding the other one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a new rule - we can pay for accounts that we created and that are less than 48 hours old
This allows EOS users to onboard in peace without running into CPU / NET problems.