-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update account import #250
Changes from 5 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,12 +22,13 @@ class ProfileService { | |
final map = Map<String, dynamic>.from(response.data); | ||
return Result.value(ProfileData.fromJson(map, user.network, [])); | ||
} else { | ||
LogHelper.e('get profile status error', stacktrace: StackTrace.current); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this doesn't happen - a 404 ends in the catch block of this try/catch because dio throws |
||
LogHelper.i('get profile status error'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lets pass the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
return Result.error(HyphaError(type: HyphaErrorType.api, message: 'server error ${response.statusMessage}')); | ||
} | ||
} catch (error, stackTrace) { | ||
// note: 500 status on get throws an error | ||
LogHelper.e('get profile error', stacktrace: stackTrace, error: error); | ||
// this happens when the profile doesn't exist, which is valid | ||
LogHelper.i('get profile error', stacktrace: stackTrace, error: error); | ||
return Result.error(HyphaError(type: HyphaErrorType.api, message: 'server error $error')); | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we be changing these endpoints in firebase and not locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was changing them in firebase, but the local app doesn't update for whatever reason.
The mobile phones were updating correctly