Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ProposalDetail): do not append [COMPLETION] #2667

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

plitzenberger
Copy link
Contributor

When trying to complete quests with a title longer than 50 characters, the smart-contract rejects the call.

@plitzenberger plitzenberger requested a review from n13 December 1, 2024 17:49
Copy link

vercel bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dho-web-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 5:49pm

Copy link
Contributor

@n13 n13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the best PRs ever. This is very simple and will work ;)

@plitzenberger
Copy link
Contributor Author

One of the best PRs ever. This is very simple and will work ;)

Yeah, these are my favorite pull requests - fixes by deletion.

So, can I merge even though the pipeline fails @n13?

@plitzenberger plitzenberger merged commit 8b7a454 into master Dec 2, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants