-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin zarr >=2,<3 #351
Pin zarr >=2,<3 #351
Conversation
I think I should have a bit more on top of this. Let's merge and make a release. I'll try to scope out what adding support for zarr 3.0.0 looks like today. Edit: Let's merge once the CI passes 😅 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage 87.84% 87.84%
=======================================
Files 85 85
Lines 11246 11246
Branches 2084 2084
=======================================
Hits 9879 9879
Misses 868 868
Partials 499 499 ☔ View full report in Codecov by Sentry. |
I was aware this was coming of the warning in the test suite and I started a branch a while ago on this but I was expecting the release not to be so soon! 😅 |
I was aware of this too but kind of thought they were a bit stuck with trying to optimize things so I figured it might be a little bit. I guess someone got a lot of work done over the winter break 😅 |
It seems like they are not planning to support object dtypes which seems like a large issue for us... zarr-developers/zarr-python#2617 |
Zarr 3.0 has been released yesterday and has breaking changes. See https://zarr.readthedocs.io/en/v3.0.0/user-guide/v3_migration.html for more context. Until we support zarr 3, we need to make a release with zarr pin to <3.
@CSSFrancis, @jlaehne, we should merge this PR and make a release ASAP.
Progress of the PR
>=2, <3
,upcoming_changes
folder (seeupcoming_changes/README.rst
),docs/readthedocs.org:rosettasciio
build of this PR (link in github checks)