Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin zarr >=2,<3 #351

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Pin zarr >=2,<3 #351

merged 3 commits into from
Jan 10, 2025

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Jan 10, 2025

Zarr 3.0 has been released yesterday and has breaking changes. See https://zarr.readthedocs.io/en/v3.0.0/user-guide/v3_migration.html for more context. Until we support zarr 3, we need to make a release with zarr pin to <3.

@CSSFrancis, @jlaehne, we should merge this PR and make a release ASAP.

Progress of the PR

  • Pin zarr to >=2, <3,
  • [n/a] update docstring (if appropriate),
  • update user guide (if appropriate),
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:rosettasciio build of this PR (link in github checks)
  • [n/a] add tests,
  • ready for review.

@ericpre ericpre changed the title Pin zarr Pin zarr >=2,<3 Jan 10, 2025
@CSSFrancis
Copy link
Member

CSSFrancis commented Jan 10, 2025

I think I should have a bit more on top of this. Let's merge and make a release. I'll try to scope out what adding support for zarr 3.0.0 looks like today.

Edit: Let's merge once the CI passes 😅

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (85a2d9d) to head (8c6bbde).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files          85       85           
  Lines       11246    11246           
  Branches     2084     2084           
=======================================
  Hits         9879     9879           
  Misses        868      868           
  Partials      499      499           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericpre
Copy link
Member Author

ericpre commented Jan 10, 2025

I was aware this was coming of the warning in the test suite and I started a branch a while ago on this but I was expecting the release not to be so soon! 😅
Overall, I don't think that much is needed but I didn't check the support of files written with zarr version 2, though...

@ericpre ericpre merged commit ef90ceb into hyperspy:main Jan 10, 2025
33 checks passed
@CSSFrancis
Copy link
Member

I was aware this was coming of the warning in the test suite and I started a branch a while ago on this but I was expecting the release not to be so soon!

I was aware of this too but kind of thought they were a bit stuck with trying to optimize things so I figured it might be a little bit. I guess someone got a lot of work done over the winter break 😅

@CSSFrancis
Copy link
Member

CSSFrancis commented Jan 10, 2025

It seems like they are not planning to support object dtypes which seems like a large issue for us... zarr-developers/zarr-python#2617

@ericpre ericpre added this to the v0.7.1 milestone Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants