Allow smoother Single image selection #133
Conversation
when a single image selection mode is selected (by setting imageLimit to 1) the controller doesn't select the image until the user manually deselects the previous one, this modification automatically removes the last picked image to allow for the new image to be selected in single image selection mode.
Allow smoother Single image selection
|
Hi @omaraltayyan, sorry for the lack of follow up, Gallery was entered into maintenance mode and didn't have someone following up issues. Since it's been a while since you submitted this I'm wondering if it's still relevant. Thanks for your time and have a nice week. |
Hi, thanks for the reply, i actually changed my entire field of work when that PR was posted, if u find the code to make sense or need modification feel free to work on it, i wish u all the best |
|
I understand, crazy how much can happen in 2 years. Take care. |
|
@3lvis i remembered something about this PR, we actually tested this and deployed it, it makes the behavior much better, so now if the limit of the selection is 1, you get a "Radio Button" like behavior, deselecting the previous image when a new one is selected, previously it required the user to deselect the image manually before selecting a new one, this fixes its behavior very well. |
|
@omaraltayyan I'll take a look, thanks! |
|
Hi is this implemented as I too was looking someway if only one image selection is allowed then it should be like when a new image is selected the previous one should get deselected. |
this was working when I implemented it, i don't know if they changed this code now or not, but i remember we tested it thoroughly and it was working pretty well |
when a single image selection mode is selected (by setting imageLimit to 1) the controller doesn't select the image until the user manually deselects the previous one, this modification automatically removes the last picked image to allow for the new image to be selected in single image selection mode.