Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make fixes to ed25519 sign method + improve tests #195

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

elribonazo
Copy link
Contributor

Description:

After some investigation, we are returning a hex encoded buffer with the signature in JS which causes compatibility issues across SDK and we are also improving the test coverage for ed25519 by using the same values on all platforms we test

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Copy link

github-actions bot commented Sep 30, 2024

Code Coverage

File Coverage [65.00%]
apollo/src/jsMain/kotlin/org/hyperledger/identus/apollo/utils/KMMEdPrivateKey.kt 54.55%
apollo/src/jsMain/kotlin/org/hyperledger/identus/apollo/utils/KMMEdPublicKey.kt 77.78%
Total Project Coverage 88.94%

@elribonazo elribonazo merged commit 354c9bd into main Oct 23, 2024
5 checks passed
@elribonazo elribonazo deleted the feature/improve-ed branch October 23, 2024 10:40
@hyperledger-bot
Copy link
Member

🎉 This PR is included in version 1.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants