Nonroot User in Docker Image #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onelapahead
requested review from
awrichar,
peterbroadhurst,
nguyer and
shorsher
as code owners
Signed-off-by: hfuss <[email protected]>
nguyer
reviewed
Oct 10, 2023
Comment on lines
+26
to
+28
| RUN chgrp -R 0 /app/ \ | ||
| && chmod -R g+rwX /app/ | ||
| USER 1001 |
There was a problem hiding this comment.
I think this one might have the same problem as the other PR that you fixed
There was a problem hiding this comment.
It should not because in this one we're assuming the USER till after we've done everything else.
I may refactor one or the other Dockerfiles to be more consistent with when we do npm i's and with what users once I've tested out these images at runtime. Because right now these similar runtimes go about their dockerfiles / bundling a bit different for reasons I don't yet appreciate.
nguyer
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to support arbitrary user IDs, or non-root numeric users, for running in clouds like OpenShift.