Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump fabric-chaincode-go #5105

Merged
merged 2 commits into from
Jan 21, 2025
Merged

bump fabric-chaincode-go #5105

merged 2 commits into from
Jan 21, 2025

Conversation

pfi79
Copy link
Contributor

@pfi79 pfi79 commented Jan 15, 2025

@denyeart
Copy link
Contributor

Having a Draft PR open to prepare the change is fine by me, but let's wait for fabric-chaincode-go to get completely settled and released before we bump the version in core fabric.

@pfi79 pfi79 force-pushed the bump-fabric-chaincode-go branch from 7585310 to 06cbe2f Compare January 17, 2025 05:05
@pfi79 pfi79 marked this pull request as ready for review January 17, 2025 05:09
@pfi79 pfi79 requested a review from a team as a code owner January 17, 2025 05:09
@pfi79 pfi79 force-pushed the bump-fabric-chaincode-go branch 5 times, most recently from ba03229 to 6231b13 Compare January 21, 2025 18:17
denyeart
denyeart approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@denyeart denyeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good... let's see if github makes us rebase given my recent update to go.mod.

pfi79 added 2 commits January 21, 2025 21:39
@pfi79
bump fabric-chaincode-go
c425627 
Signed-off-by: Fedor Partanskiy <[email protected]>
@pfi79
bump fabric-chaincode-go to v2.1.0
314b4e3 
Signed-off-by: Fedor Partanskiy <[email protected]>
@denyeart
Copy link
Contributor

Not a huge deal but we usually don't like to have multiple commits in a PR that supersede each other. I usually do git commit --amend to keep a clean commit history. More details at https://hyperledger-fabric.readthedocs.io/en/latest/github/github.html#updating-a-pull-request

@pfi79 pfi79 force-pushed the bump-fabric-chaincode-go branch from 6231b13 to 314b4e3 Compare January 21, 2025 18:41
@pfi79
Copy link
Contributor Author

pfi79 commented Jan 21, 2025

This looks good... let's see if github makes us rebase given my recent update to go.mod.

I didn't wait, I made a rebase.

@pfi79
Copy link
Contributor Author

pfi79 commented Jan 21, 2025

Not a huge deal but we usually don't like to have multiple commits in a PR that supersede each other. I usually do git commit --amend to keep a clean commit history. More details at https://hyperledger-fabric.readthedocs.io/en/latest/github/github.html#updating-a-pull-request

I can close, redo and open a new pr.

@pfi79 pfi79 merged commit c3e868c into hyperledger:main Jan 21, 2025
15 checks passed
@pfi79 pfi79 deleted the bump-fabric-chaincode-go branch January 21, 2025 19:07
@denyeart
Copy link
Contributor

Sorry I broke your PR :-)
I just prefer to do incremental dependency updates in case something breaks...

@pfi79
Copy link
Contributor Author

pfi79 commented Jan 21, 2025

Sorry I broke your PR :-) I just prefer to do incremental dependency updates in case something breaks...

No, no, don't be sorry. You did the right thing. I don't like big changes myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denyeart denyeart denyeart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfi79 @denyeart