change StartWriteBatch

[pfi79]

hyperledger/fabric#5086

[bestbeforetoday]

What do we expect the smart contract implementation to do based on the return value from StartWriteBatch()? Does the smart contract implementation logic need to do something different, like avoid calling other batching operations, or can it continue unchanged?

If the smart contract logic needs to react to the return value, the documentation should probably be clear about what action needs to be taken.

If the smart contract code can be identical regardless of return value, maybe it's not necessary.

[pfi79]

What do we expect the smart contract implementation to do based on the return value from StartWriteBatch()? Does the smart contract implementation logic need to do something different, like avoid calling other batching operations, or can it continue unchanged?

If the smart contract logic needs to react to the return value, the documentation should probably be clear about what action needs to be taken.

If the smart contract code can be identical regardless of return value, maybe it's not necessary.

Currently, the return value of StartWriteBatch() will only affect the call to ResetWriteBatch().
If it returns true, the ResetWriteBatch() call will reset the batched changes and they will not pass to the peer.
If it returns false, the ResetWriteBatch() call will not change the data that has already changed, it has already passed to the peer.

[denyeart]

This is a good example of the complexity that I'd like to avoid. The existence of ResetWriteBatch is now bleeding into other APIs. I'd prefer to eliminate ResetWriteBatch and the extra baggage that it brings along.