Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade configtxgen to v2.5.9 #636

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

YoungHypo
Copy link
Collaborator

@YoungHypo YoungHypo commented Sep 21, 2024

Summary of changes:

  1. According to the latest Configtxgen-Usage, "channeltx" function has been deprecated, which should be replaced by "genesis" function from <src/api-engine/api/lib/configtxgen/configtxgen.py>
  2. Since the system channel is no longer supported (a system channel genesis block is unnecessary before creating a orderer service), delete the operations of configtx and configtxgen in the create func from <src/api-engine/api/routes/network/views.py>.
  3. Only perform genesis block creation once in channel's create function (configtxgen.genesis) from <src/api-engine/api/routes/channel/views.py> .

@YoungHypo YoungHypo requested a review from a team September 21, 2024 17:47
@YoungHypo YoungHypo mentioned this pull request Sep 27, 2024
6 tasks
@yeasy
Copy link
Member

yeasy commented Sep 28, 2024

--> osnadmin to do channel creation (channel join).

@yeasy yeasy merged commit 2b88445 into hyperledger:main Sep 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants