fix: fixes and improvements Update besu-entry.sh #8107
+38
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
I’ve made several updates to address issues and improve the script’s reliability, readability, and maintainability.
Here’s a summary of the changes:
exit 0
afterexec
to ensure the script terminates immediately, preventing unintended behavior.BESU_USER_NAME
to avoid errors from undefined variables.besu --print-paths-and-exit
command to fail early if the command fails.IFS=:
withcut
to correctly handle paths with spaces or special characters.echo
statements for better debugging and progress tracking.Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests