Log calculated world state contents upon state root mismatch #8099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Dudley <[email protected]>
Collect trielog rolling exceptions and display upon state root mismatch Tidy up assertions and world state logging Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
|
Example output |
matkt
requested changes
Jan 14, 2025
| .map( | ||
| e -> | ||
| Map.entry( | ||
| e.getKey().orElse(UInt256.ZERO), |
There was a problem hiding this comment.
displaying zero is not true, I will prefer return Bytes.EMPTY in this case
There was a problem hiding this comment.
Fine by me. Note, ZERO was somewhat following suit with
| if (!storageEntries.isEmpty()) { | ||
| accountJson.set("storage", storageJson); | ||
| } | ||
| worldStateJson.set(account.getAddress().orElse(Address.ZERO).toHexString(), accountJson); |
There was a problem hiding this comment.
same here, I don't think we will trigger this case but I will prefer to see that it was empty and no think that the address is the ZERO one
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
When running EEST tests with our referenceTests runner, if we get a state root mismatch, then dump the world state contents to make it easy to see the "post state".
Together with this recently merged EEST change: ethereum/execution-spec-tests#1064
We should be able to do a direct comparison of the calculated versus expected post state.
"Collect" exceptions during trie log rolling validation and assert together with the state root.