Ignore gasPrice if 1559 gas params are specified #8059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
macfarla
commented
Dec 20, 2024
...n/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/JsonCallParameterUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sally MacFarlane <[email protected]>
garyschulte
pushed a commit
that referenced
this pull request
Dec 20, 2024
* don't throw if all the gasprice params are specified Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]>
siladu
pushed a commit
to siladu/besu
that referenced
this pull request
Dec 21, 2024
* don't throw if all the gasprice params are specified Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]>
siladu
pushed a commit
to siladu/besu
that referenced
this pull request
Dec 22, 2024
* don't throw if all the gasprice params are specified Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sally MacFarlane [email protected]
PR description
Previously we were returning an error response if gasPrice was specified along with maxFeePerGas or maxPriorityFeePerGas.
This PR modifies that to accept requests that specify both (legacy and 1559) types of gas pricing params.
No change made to the TransactionSimulator as it uses the 1559 values if they are present, so in this case gasPrice is effectively ignored.
Also added some logging for parameters if there is an InvalidJsonRpcParameters exception
This affects
Fixed Issue(s)
fixes #8055
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests