wip: add workflow to verify artifacts #8056
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuafernandes
force-pushed
the
verify-artifacts
branch
4 times, most recently
from
519da4f to
e334153
Compare
Signed-off-by: Joshua Fernandes <[email protected]>
joshuafernandes
force-pushed
the
verify-artifacts
branch
from
e334153 to
4f233ca
Compare
macfarla
reviewed
Dec 19, 2024
| "https://hyperledger.jfrog.io/hyperledger/besu-maven/org/hyperledger/besu/evm/VERSION/evm-VERSION-sources.jar", | ||
| "https://hyperledger.jfrog.io/hyperledger/besu-maven/org/hyperledger/besu/internal/enclave/VERSION/enclave-VERSION.module", | ||
| "https://hyperledger.jfrog.io/hyperledger/besu-maven/org/hyperledger/besu/internal/nat/VERSION/nat-VERSION.jar", | ||
| "https://hyperledger.jfrog.io/hyperledger/besu-maven/org/hyperledger/besu/internal/enclave/VERSION/enclave-VERSION.pom", |
There was a problem hiding this comment.
this is a very long list! are there any issues with having so many?
Also some of these are on the deprecated list so within 6 months we will remove - enclave, privacy
prob don't need sources.jar verified for all?
There was a problem hiding this comment.
Aye, that makes sense - no issues per say will take an extra couple of secs per artifact to check.
Do we have a core list of artifacts I can check against?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add workflow step to verify artifacts are published and can be downloaded
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.