Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGELOG] clarify breaking changes #8052

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Dec 19, 2024

Signed-off-by: Sally MacFarlane [email protected]## PR description

There were some breaking changes that are already released in 24.12 - removed those from the "upcoming breaking changes" section.

Also clarified a comment.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <[email protected]>
Copy link
Contributor

@Matilda-Clerke Matilda-Clerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla enabled auto-merge (squash) December 19, 2024 00:39
@macfarla macfarla merged commit 0448af8 into hyperledger:main Dec 19, 2024
43 checks passed
@macfarla macfarla deleted the changelog-breaking-changes branch December 19, 2024 07:16
garyschulte pushed a commit that referenced this pull request Dec 20, 2024
* clarify breaking changes in changelog

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants