Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simulate pending block timestamp #8027

Merged

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Dec 13, 2024

PR description

Correctly set the timestamp field of the pending block, that was wrongly set to milliseconds in #7951

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla macfarla merged commit 566583c into hyperledger:main Dec 16, 2024
43 checks passed
@fab-10 fab-10 deleted the fix-simulate-pending-block-timestamp branch December 16, 2024 08:32
daniellehrner pushed a commit to daniellehrner/besu that referenced this pull request Dec 18, 2024
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants