-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement the proposed gas changes for bls / eip-2537 #8008
Merged
garyschulte
merged 10 commits into
hyperledger:main
from
garyschulte:updated-bls12-spec-devnet5
Jan 10, 2025
Merged
implement the proposed gas changes for bls / eip-2537 #8008
garyschulte
merged 10 commits into
hyperledger:main
from
garyschulte:updated-bls12-spec-devnet5
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
force-pushed
the
updated-bls12-spec-devnet5
branch
5 times, most recently
from
December 16, 2024 15:42
c84dd60
to
6baeabe
Compare
garyschulte
force-pushed
the
updated-bls12-spec-devnet5
branch
3 times, most recently
from
December 20, 2024 00:38
23362ee
to
8234f19
Compare
garyschulte
force-pushed
the
updated-bls12-spec-devnet5
branch
2 times, most recently
from
December 20, 2024 04:07
32106bc
to
3c2a5ff
Compare
garyschulte
force-pushed
the
updated-bls12-spec-devnet5
branch
from
January 7, 2025 00:00
3c2a5ff
to
3098eb9
Compare
Signed-off-by: garyschulte <[email protected]>
…m/EIPs@92c94cf Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
…/files Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
…tra gas costs Signed-off-by: garyschulte <[email protected]>
garyschulte
force-pushed
the
updated-bls12-spec-devnet5
branch
from
January 9, 2025 20:58
3098eb9
to
44a03f2
Compare
siladu
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
implement proposed gas cost changes in:
https://github.com/ethereum/EIPs/pull/9097/files
https://github.com/ethereum/EIPs/pull/9098/files
https://github.com/ethereum/EIPs/pull/9116/files
https://github.com/ethereum/EIPs/pull/8945/files
This PR ignores eip-2537 reference tests until we have updated test artifacts that reflect the updated gas costs.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests