Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement the proposed gas changes for bls / eip-2537 #8008

Merged
merged 10 commits into from
Jan 10, 2025

Conversation

garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Dec 9, 2024

PR description

implement proposed gas cost changes in:
https://github.com/ethereum/EIPs/pull/9097/files
https://github.com/ethereum/EIPs/pull/9098/files
https://github.com/ethereum/EIPs/pull/9116/files
https://github.com/ethereum/EIPs/pull/8945/files

This PR ignores eip-2537 reference tests until we have updated test artifacts that reflect the updated gas costs.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@garyschulte garyschulte force-pushed the updated-bls12-spec-devnet5 branch 5 times, most recently from c84dd60 to 6baeabe Compare December 16, 2024 15:42
@garyschulte garyschulte force-pushed the updated-bls12-spec-devnet5 branch 3 times, most recently from 23362ee to 8234f19 Compare December 20, 2024 00:38
@garyschulte garyschulte force-pushed the updated-bls12-spec-devnet5 branch 2 times, most recently from 32106bc to 3c2a5ff Compare December 20, 2024 04:07
@garyschulte garyschulte force-pushed the updated-bls12-spec-devnet5 branch from 3c2a5ff to 3098eb9 Compare January 7, 2025 00:00
@garyschulte garyschulte force-pushed the updated-bls12-spec-devnet5 branch from 3098eb9 to 44a03f2 Compare January 9, 2025 20:58
@garyschulte garyschulte marked this pull request as ready for review January 9, 2025 20:58
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garyschulte garyschulte enabled auto-merge (squash) January 10, 2025 00:09
@garyschulte garyschulte merged commit 2aadbfc into hyperledger:main Jan 10, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants