EIP-7756 Trace updates #8006
Draft
EIP-7756 Trace updates #8006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shemnon
commented
Dec 9, 2024
| new StandardJsonTracer(out, showMemory, true, true, false), | ||
| // FIXME // REVIEWME do we want to change the JSON | ||
| // debug calls to use EIP-7756 values for gas and opcode? | ||
| new StandardJsonTracer(out, showMemory, true, true, false, true), |
There was a problem hiding this comment.
Do we want to extend this to JSON-RPC calls? Currently this only impacts CLI tools (and those have a CLI override flag).
Update tracing for EIP-7756 changes, mostly swapping hex format and numbers for opcode and gas members. Signed-off-by: Danno Ferrin <[email protected]>
EIP-3155 and EIP-7756 call for "stateRoot" where we use "postHash". Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
shemnon
force-pushed
the
eip-7756/gas-as-numbers
branch
from
1470a95 to
338e491
Compare
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Update tracing for EIP-7756 changes, mostly swapping hex format and numbers for opcode and gas members.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests