Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include mention of 24 hours notice for confirmation of outstanding PRs #8004

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Include mention of 24 hours notice for confirmation of outstanding PRs #8004

merged 2 commits into from
Dec 9, 2024

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Dec 9, 2024 •
edited
Loading

PR description

Update release checklist to include mention of 24 hours notice for confirmation of outstanding PRs

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@jframe jframe merged commit 4e30095 into hyperledger:main Dec 9, 2024
43 checks passed
@jframe jframe deleted the release_checklist_pending_pr_wait branch December 9, 2024 04:35
daniellehrner pushed a commit to daniellehrner/besu that referenced this pull request Dec 18, 2024
@jframe @daniellehrner
Include mention of 24 hours notice for confirmation of outstanding PR…
18c75dc 
…s in the release checklist (hyperledger#8004)

Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jframe @macfarla