-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RPC HTTP options to specify custom truststore and password #7978
Add RPC HTTP options to specify custom truststore and password #7978
Conversation
Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
besu/src/main/java/org/hyperledger/besu/cli/options/JsonRpcHttpOptions.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
…nto 7932-rpc-http-truststore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the error messages, it's helpful for the user to indicate exactly which CLI option is missing or required. Otherwise i think it's looking good
besu/src/main/java/org/hyperledger/besu/cli/options/JsonRpcHttpOptions.java
Outdated
Show resolved
Hide resolved
besu/src/main/java/org/hyperledger/besu/cli/options/JsonRpcHttpOptions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bhanu Pulluri <[email protected]>
…nto 7932-rpc-http-truststore
besu/src/main/java/org/hyperledger/besu/cli/options/JsonRpcHttpOptions.java
Outdated
Show resolved
Hide resolved
besu/src/main/java/org/hyperledger/besu/cli/options/JsonRpcHttpOptions.java
Outdated
Show resolved
Hide resolved
…pOptions.java Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Bhanu Pulluri <[email protected]>
…pOptions.java Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
There is a unit test failing. You can run these tests locally, this will benefit your time and reviewers. You'll get feedback waaaayy faster. converting to draft since it's not ready to review
|
Signed-off-by: Bhanu Pulluri <[email protected]>
I agree, no change is too small to skip running local tests. Fixed and ran the tests locally. |
…ledger#7978) * Add RPC HTTP options to specify custom truststore and it's password * Update error logs to indicate options to use Signed-off-by: Bhanu Pulluri <[email protected]> --------- Signed-off-by: Bhanu Pulluri <[email protected]> Signed-off-by: Bhanu Pulluri <[email protected]> Co-authored-by: Bhanu Pulluri <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
PR description
Fixed Issue(s)
#7932