eth_simulateV1 - Add BlockSimulator feature #7941

Gabriel-Trintinalia · 2024-11-27T05:51:45Z

Pull Request Description

This pull request introduces a new Block Simulation feature that allows users to simulate multiple transaction calls sequentially, overriding the state and block values for the execution context.

Key Features:

State Override Reuse: This feature reuses the State override classes and parameters that were implemented for eth_call in PR #7892.
Block Overrides Implementation: It also implements block override classes that will be used in issue #7822.
Base Implementation for eth_simulateV1: This PR serves as the base implementation for the eth_simulateV1 method.
BlockSimulationService: A new BlockSimulationService is introduced, providing plugins with the flexibility to simulate blocks like Besu's TransactionSimulator.

Spec: ethereum/execution-apis#484

TODO:

Implement the eth_simulateV1 JSON-RPC method to handle block simulation requests as outlined in issue #6203. The implementation was initially included in this PR but was split for easier review.
Add logs and transfer logs.
Support withdrawals.
Add tons of tests

Signed-off-by: Gabriel-Trintinalia <[email protected]>

besu/src/main/java/org/hyperledger/besu/services/BlockSimulatorServiceImpl.java

datatypes/src/main/java/org/hyperledger/besu/datatypes/BlockOverrides.java

pinges

Added a few questions

besu/src/main/java/org/hyperledger/besu/services/BlockSimulatorServiceImpl.java

datatypes/src/main/java/org/hyperledger/besu/datatypes/BlockOverrides.java

...pi/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/BlockResult.java

...reum/core/src/main/java/org/hyperledger/besu/ethereum/transaction/BlockSimulationResult.java

pinges · 2024-12-13T02:25:21Z

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/transaction/BlockStateCall.java

+
+  private final boolean validation;
+
+  public BlockStateCall(


should that be BlockStateCalls?

pinges · 2024-12-13T02:38:19Z

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/transaction/BlockSimulator.java

+      final List<? extends BlockStateCall> blockStateCalls,
+      final MutableWorldState worldState) {
+    List<BlockSimulationResult> simulationResults = new ArrayList<>();
+    for (BlockStateCall blockStateCall : blockStateCalls) {


When you are simulating multiple blocks, does it make sense that each of the blockStateCalls has it's own blockOverrides?

…rServiceImpl.java Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]>

…saction/BlockSimulationResult.java Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]>

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Matilda-Clerke

Can't comment too much the changes themselves, but added a few about generic stuff

ethereum/core/src/test/java/org/hyperledger/besu/ethereum/transaction/BlockSimulatorTest.java

Matilda-Clerke · 2024-12-13T04:49:10Z

ethereum/core/src/test/java/org/hyperledger/besu/ethereum/transaction/BlockSimulatorTest.java

+        blockSimulator.process(blockHeader, Collections.emptyList());
+
+    assertNotNull(results);
+    verify(worldStateArchive).getMutable(any(BlockHeader.class), eq(false));


Nit: It's usually best to verify mock calls before asserting the results, since incorrect or unexpected calls can produce incorrect results and verifying before asserting can help catch this with less investigation

ethereum/core/src/test/java/org/hyperledger/besu/ethereum/transaction/BlockSimulatorTest.java

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Matilda-Clerke

LGTM, but I'll leave unapproved for the others to approved

jframe

LGTM 🚢

macfarla

prob worth a changelog? or wait for the RPC

macfarla · 2024-12-18T05:45:15Z

plugin-api/src/main/java/org/hyperledger/besu/plugin/data/PluginBlockSimulationResult.java

+import java.util.List;
+
+/** This class represents the result of simulating the processing of a block. */
+public class PluginBlockSimulationResult {


why PluginBlockSimulationResult - how does this relate to BlockSimulationResult

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Gabriel-Trintinalia added 30 commits November 22, 2024 18:01

initial implementation of block simulator

4be39be

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Implement eth_simulateV1

668176e

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Implement simulate v1

924efbc

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Remove blockchain

36393c4

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Add initial test for simulate v1

0de4e65

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Simplify code

5778e0a

Signed-off-by: Gabriel-Trintinalia <[email protected]>

remove non necessary code

1964c3a

Signed-off-by: Gabriel-Trintinalia <[email protected]>

remove non necessary code

652f4a5

Signed-off-by: Gabriel-Trintinalia <[email protected]>

remove non necessary code

ac53d95

Signed-off-by: Gabriel-Trintinalia <[email protected]>

merge main

38bb8de

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Simplify code

71dc684

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Simplify code

572244a

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Simplify code

91d9645

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Simplify code

2615eb5

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Refactor code

612ffc9

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Add transaction processing result to output

a826054

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Simplify code

aa0d2d9

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Simplify code

c6ac81b

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Expose rest of body

1026328

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Simplify code

6382608

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Merge branch 'main' into block-simulator-service

1d113b8

Merge main into branch

46cf544

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Remove PersistingBlockSimulator

9661fed

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Bug fixes

dc9f802

Signed-off-by: Gabriel-Trintinalia <[email protected]>

merge main into branch

1df5f32

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Split PR into block simulator and eth_simulate v1

7e482e1

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Merge main

4bad506

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Refactoring

3ee61a4

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Refactoring

9f0e610

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Add tests

a3c3a20

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Gabriel-Trintinalia marked this pull request as ready for review December 11, 2024 11:02

Gabriel-Trintinalia requested review from pinges, jframe and Matilda-Clerke December 12, 2024 00:06

jframe reviewed Dec 13, 2024

View reviewed changes

pinges reviewed Dec 13, 2024

View reviewed changes

Gabriel-Trintinalia and others added 6 commits December 13, 2024 13:52

Update besu/src/main/java/org/hyperledger/besu/services/BlockSimulato…

d026c0c

…rServiceImpl.java Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]>

Update ethereum/core/src/main/java/org/hyperledger/besu/ethereum/tran…

7ab57c6

…saction/BlockSimulationResult.java Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]>

Update ethereum/core/src/main/java/org/hyperledger/besu/ethereum/tran…

a6b4597

…saction/BlockSimulationResult.java Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]>

Update ethereum/core/src/main/java/org/hyperledger/besu/ethereum/tran…

9de954d

…saction/BlockSimulationResult.java Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]>

Fix missing rename

f516105

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Fix wrong json properties

52a6d22

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Matilda-Clerke reviewed Dec 13, 2024

View reviewed changes

Gabriel-Trintinalia added 3 commits December 13, 2024 15:47

Simplify simulator service impl

74a9fb0

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Move BlockOverrides to plugin

cc0bcca

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Accept PR suggestions

6c6276f

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Gabriel-Trintinalia requested review from Matilda-Clerke, pinges and jframe December 18, 2024 04:25

Gabriel-Trintinalia added mainnet linea helps L2s using besu RPC labels Dec 18, 2024

Gabriel-Trintinalia changed the title ~~Implement eth_simulateV1 - Add Block simulator feature~~ eth_simulateV1 - Add BlockSimulator feature Dec 18, 2024

Matilda-Clerke reviewed Dec 18, 2024

View reviewed changes

jframe approved these changes Dec 19, 2024

View reviewed changes

macfarla approved these changes Dec 19, 2024

View reviewed changes

Merge branch 'main' into block-simulator-service

394bec0

Gabriel-Trintinalia enabled auto-merge (squash) December 19, 2024 04:21

Gabriel-Trintinalia merged commit a03c98b into hyperledger:main Dec 19, 2024
43 checks passed

garyschulte pushed a commit that referenced this pull request Dec 20, 2024

eth_simulateV1 - Add BlockSimulator feature (#7941)

4edde08

Signed-off-by: Gabriel-Trintinalia <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

eth_simulateV1 - Add BlockSimulator feature #7941

eth_simulateV1 - Add BlockSimulator feature #7941

Gabriel-Trintinalia commented Nov 27, 2024 •

edited

Loading

pinges left a comment

pinges Dec 13, 2024

pinges Dec 13, 2024

Matilda-Clerke left a comment

Matilda-Clerke Dec 13, 2024

Matilda-Clerke left a comment

jframe left a comment

macfarla left a comment

macfarla Dec 18, 2024

eth_simulateV1 - Add BlockSimulator feature #7941

eth_simulateV1 - Add BlockSimulator feature #7941

Conversation

Gabriel-Trintinalia commented Nov 27, 2024 • edited Loading

Pull Request Description

TODO:

pinges left a comment

Choose a reason for hiding this comment

pinges Dec 13, 2024

Choose a reason for hiding this comment

pinges Dec 13, 2024

Choose a reason for hiding this comment

Matilda-Clerke left a comment

Choose a reason for hiding this comment

Matilda-Clerke Dec 13, 2024

Choose a reason for hiding this comment

Matilda-Clerke left a comment

Choose a reason for hiding this comment

jframe left a comment

Choose a reason for hiding this comment

macfarla left a comment

Choose a reason for hiding this comment

macfarla Dec 18, 2024

Choose a reason for hiding this comment

Gabriel-Trintinalia commented Nov 27, 2024 •

edited

Loading